Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,5 @@ packages/**/*.tgz
packages/**/package-lock.json
tmp
# Verdaccio storage path
storage
storage
.ackrc
Copy link
Contributor Author

@lerouxb lerouxb Aug 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to add an .ackrc to the compass folder so I can use ack to search for code and ignore all the giant packages/*/lib/index.js files.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would have been nice if those were .min.js so it would automagically be ignored. Or so it would be easy to write an accurate ignore pattern.

3 changes: 0 additions & 3 deletions packages/compass-import-export/src/utils/import-preview.js
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,6 @@ export default function({

assert.equal(typeof key, 'string', `import-preview: expected key to be a String not ${typeof key}`);

// eslint-disable-next-line no-control-regex
key = key.replace(/[^\x00-\x7F]/g, '');

const isCSV = fileType === FILE_TYPES.CSV;
const item = { path: key, checked: true };

Expand Down