fix: Dedupe all leafygreen components across Compass plugins #2424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting them as peerDeps excludes them from the plugin webpack build so that they all can require the same version from the same location installed by compass in runtime
gribnoysup
added a commit
that referenced
this pull request
Aug 27, 2021
* fix: Dedupe all leafygreen components across compass plugins Setting them as peerDeps excludes them from the plugin webpack build so that they all can require the same version from the same location installed by compass in runtime * fix(mongodb-compass): Include all the leafygreen peer dependencies in depcheckrc * fix: No need to commit this one-shot script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having multiple instances of leafygreen components (and as such multiple instances of emotion) running on the same page seems to cause issues for emotion, resulting in styles applied on the page out of expected order, this was causing noticeable problems in e.g.,
TextInputcomponent:The fix is to dedupe the emotion instances so that only one emotion is evaluated on the page. This PR sets all leafygreen components as peer dependencies in plugins, which automatically excludes them from the webpack build. This allows them all to use the same version of the library required from the same location in runtime and resolves the issue: