fix(@mongodb-js/compass-schema-validation): Pass full namespace to updateCollection
instead of passing collMod
option
#2426
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like this was an unintentional breaking change in data-service that resulted in compass-schema-validation not being able to update schema. The schema-validation plugin saveValidation method calls
updateCollection
like this, just providing a database name in namespace and passing collMod separately:compass/packages/compass-schema-validation/src/modules/validation.js
Lines 473 to 480 in 81afb35
Before latest changes in data-service, the merge was happening in a way where
collectionName
derived from provided namespace was basically treated as a default value, not an override for whatever was provided in the options. This PR restores this behavior