fix(compass-crud): Use separate sessions for all operations in compass-crud COMPASS-5299 #2593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
approved these changes
Nov 17, 2021
gribnoysup
changed the title
gribnoysup
deleted the
compass-5299-use-separate-sessions-for-crud-ops
branch
mcasimir
approved these changes
Nov 17, 2021
| * @param clientSession - a ClientSession (can be created with startSession()) | ||
| */ | ||
| killSession(session: ClientSession): Promise<Document> { | ||
| killSession(sessions: ClientSession | ClientSession[]): Promise<Document> { |
There was a problem hiding this comment.
Suggested change
| killSession(sessions: ClientSession | ClientSession[]): Promise<Document> { | |
| killSessions(sessions: ClientSession | ClientSession[]): Promise<Document> { |
| this.setState({ sessions: null }); | ||
| try { | ||
| await this.dataService.killSession(session); | ||
| await this.dataService.killSession(sessions); |
There was a problem hiding this comment.
does this
Suggested change
| await this.dataService.killSession(sessions); | |
| await this.dataService.killSessions(sessions); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with Serverless instances of MongoDB where trying to run multiple session commands in parallel is causing driver to throw an error. We learned from the driver team that even though running concurrent session commands works in some cases, it's really not something that we should be doing, so the fix is to have a separate session for every command we are running in parallel here