-
Notifications
You must be signed in to change notification settings - Fork 235
feat(connections): adds connection menu to duplicate and remove COMPASS-5255 #2666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
626f6af
to
93c2738
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, couple comments/suggestions. Tried it out, works real smooth.
packages/connections/src/components/connection-list/connection-menu.spec.tsx
Outdated
Show resolved
Hide resolved
719c3d9
to
df6bd4a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! Two thoughts/suggestions, not blockers. Nice work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5820f8f
to
c302bbc
Compare
Description
Adds two new options in connections context menu: Duplicate and Remove.
Checklist
Motivation and Context
Types of changes