Skip to content

Conversation

leorossi
Copy link
Contributor

@leorossi leorossi commented Jan 7, 2022

Description

Adds two new options in connections context menu: Duplicate and Remove.

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@leorossi leorossi force-pushed the COMPASS-5255 branch 2 times, most recently from 626f6af to 93c2738 Compare January 11, 2022 14:29
Copy link
Member

@Anemy Anemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, couple comments/suggestions. Tried it out, works real smooth.

Copy link
Member

@Anemy Anemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Two thoughts/suggestions, not blockers. Nice work

@leorossi leorossi requested a review from Anemy January 18, 2022 14:14
Copy link
Member

@Anemy Anemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@leorossi leorossi merged commit 6faadc8 into main Jan 20, 2022
@leorossi leorossi deleted the COMPASS-5255 branch January 20, 2022 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants