Skip to content

Conversation

addaleax
Copy link
Collaborator

This enables connecting to replica sets and setups that use TLS
usings SSH tunnels, and includes a driver update to 4.3.0.


Note that this cannot land until we also have an updated mongosh, because mongosh
bundles its own Node.js driver version, and the previous one fails because it does
not understand the Socks5 connection options.

Description

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@addaleax addaleax force-pushed the 5156-dev branch 3 times, most recently from 55f8e2b to e197f26 Compare January 11, 2022 19:09
@addaleax addaleax force-pushed the 5156-dev branch 2 times, most recently from 1b67bd7 to 462fef1 Compare January 11, 2022 20:40
@addaleax addaleax marked this pull request as ready for review January 11, 2022 20:41
This enables connecting to replica sets and setups that use TLS
usings SSH tunnels, and includes a driver update to 4.3.0.
Copy link
Member

@Anemy Anemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Nice work adding this into node and now here! Looking at the driver update https://github.com/mongodb/node-mongodb-native/releases/tag/v4.3.0 looks good, don't see there being any issues.

Let's definitely test that past ssh tunnel connections still work as expected (looks like they should be fine but a manual test will make me feel even better lol).

@addaleax
Copy link
Collaborator Author

Alright, with the build from this PR I have manually tested:

  • That SSH to a single, non-TLS endpoint works
  • That SSH to a single, TLS-enabled endpoint works
  • That SSH to a TLS-enabled Atlas replicaset with network access restrictions now also works

I’d say that’s good enough for me to merge this.

@addaleax addaleax merged commit 042c6fa into main Jan 12, 2022
@addaleax addaleax deleted the 5156-dev branch January 12, 2022 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants