feat(connect-form): Add save connection modal COMPASS-5277 #2698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anemy
commented
Jan 19, 2022
Anemy
commented
Jan 19, 2022
mcasimir
reviewed
Jan 19, 2022
mcasimir
reviewed
Jan 19, 2022
packages/connect-form/src/components/saved-connection-color-picker.tsx
Outdated
Show resolved
Hide resolved
mcasimir
reviewed
Jan 19, 2022
mcasimir
reviewed
Jan 19, 2022
mcasimir
reviewed
Jan 19, 2022
mcasimir
reviewed
Jan 19, 2022
gribnoysup
reviewed
Jan 19, 2022
packages/compass-components/src/components/icons/favorite-icon.tsx
Outdated
Show resolved
Hide resolved
mcasimir
approved these changes
Jan 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMPASS-5277
Currently there are 2 entry points, the pencil and the favorite button. I'm chatting with Claudia on which one to keep, any preferences?
Currently saving a connection saves any changes made to the connection string (including invalid ones). This means a user can now save an invalid connection string. I think this probably is a nicer experience for a user so they can be actively editing a connection string, click the save button, keep editing it, then click save again if they want. Without having to have it valid first.
This modal will be used inside of Compass when connected with the favorite button on the sidebar, but that work will happen in a followup pr for compass-sidebar (this pr just adds the saving favorite for the connect form and exports it).
Here's how it looks:
save.connection.mp4