feat(connect-form): add support for MONGODB_AWS COMPASS-5439 #2726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
approved these changes
Jan 26, 2022
Anemy
approved these changes
Jan 26, 2022
| export const GSSAPI_PRINCIPAL_NAME_LABEL = 'Principal'; | ||
| export const GSSAPI_SERVICE_NAME_LABEL = 'Service Name'; | ||
| export const GSSAPI_CANONICALIZE_HOST_NAME_LABEL = 'Canonicalize Host Name'; | ||
| export const GSSAPI_SERVICE_REALM_LABEL = 'Service Realm'; |
There was a problem hiding this comment.
This might be a totally unnecessary thing I do, but with things like label names I like to not export them for tests if possible and instead make them hardcoded strings. It does mean that every time a label is updated we need to update the test, but I think that helps make the test a bit more solid and regression safe if the label accidentally has a typo added or something.
There was a problem hiding this comment.
that's a good point, i'll revert everything in the next one :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.