Skip to content

Conversation

mcasimir
Copy link
Collaborator

@mcasimir mcasimir commented Jan 26, 2022

Screenshot 2022-01-26 at 18 44 02

Screenshot 2022-01-26 at 18 51 14

@mcasimir mcasimir changed the title feat(connect-form): Add auth plain and x509 COMPASS-5436, COMPASS-5437 feat(connect-form): Add PLAIN and x509 auth mechanisms COMPASS-5436, COMPASS-5437 Jan 26, 2022
username: value,
});
}}
label={PLAIN_USERNAME_LABEL}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar question here to the last one, do we want to add an info link like we currently have in Compass?
Screen Shot 2022-01-26 at 12 53 16 PM
links to https://docs.mongodb.com/manual/core/security-ldap/

Copy link
Collaborator Author

@mcasimir mcasimir Jan 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was chatting with Claudia about these, considering that it would require a "custom component" I would remove all of them. Possibly replacing it with a more generic help for the whole auth method.

Although I would argue that our goal should not be to teach our users what LDAP is and how it works but only make them know how to connect to MongoDB with LDAP.

If you look into that page, i do not believe that a user would get any real help to connect, that's all the "client" part says about it: https://docs.mongodb.com/manual/core/security-ldap/#connect-to-a-mongodb-server-via-ldap-authentication

FYI @Sgrinfy

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use the info icon on a text input for the authentication database already:
Screen Shot 2022-01-26 at 1 11 07 PM
I see what you mean, the current link probably doesn't help people out much. I'm cool with removing it 👍

@mcasimir mcasimir requested a review from Anemy January 26, 2022 18:11
Copy link
Member

@Anemy Anemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mcasimir mcasimir merged commit 617205f into main Jan 26, 2022
@mcasimir mcasimir deleted the add-auth-plain-and-x509 branch January 26, 2022 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants