feat(connect-form): Add error and warning indicators to tabs COMPASS-5451 #2731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gribnoysup
reviewed
Jan 28, 2022
packages/connect-form/src/components/advanced-options-tabs/advanced-options-tabs.tsx
Outdated
Show resolved
Hide resolved
packages/connect-form/src/components/advanced-options-tabs/advanced-options-tabs.tsx
Outdated
Show resolved
Hide resolved
packages/connect-form/src/components/advanced-options-tabs/advanced-options-tabs.tsx
Outdated
Show resolved
Hide resolved
packages/connect-form/src/components/advanced-options-tabs/advanced-options-tabs.tsx
Outdated
Show resolved
Hide resolved
packages/connect-form/src/components/advanced-options-tabs/advanced-options-tabs.tsx
Outdated
Show resolved
Hide resolved
packages/connect-form/src/components/advanced-options-tabs/advanced-options-tabs.tsx
Outdated
Show resolved
Hide resolved
packages/connect-form/src/components/advanced-options-tabs/advanced-options-tabs.tsx
Outdated
Show resolved
Hide resolved
mcasimir
reviewed
Jan 28, 2022
packages/connect-form/src/components/advanced-options-tabs/advanced-options-tabs.tsx
Outdated
Show resolved
Hide resolved
mcasimir
reviewed
Jan 28, 2022
mcasimir
reviewed
Jan 28, 2022
mcasimir
reviewed
Jan 28, 2022
mcasimir
approved these changes
Jan 31, 2022
Anemy
deleted the
COMPASS-5451-add-error-warning-indicators-to-connect-form-tabs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMPASS-5451
This adds an indicator to connect form tabs when there's an error that can be mapped to a tab. Currently we're only adding these indicators for errors that have a field we can reference so that the indicator hopefully guides an action. When reviewing maybe run through the errors we show to see if any are missed or could use no indicator.
Here's how it looks (made the dots 1 pixel bigger after this video):
tab.error-warning.indicator.mp4