feat(connect-form): auto add advanced options and remove button #2738
Conversation
|
|
||
| describe('with SearchParams', function () { | ||
| beforeEach(function () { | ||
| cleanup(); |
There was a problem hiding this comment.
Why in the beforeEach and not afterEach?
There was a problem hiding this comment.
looks like a leftover
| } | ||
| > | ||
| <Cell> | ||
| <Cell className={optionNameCellStyles}> |
There was a problem hiding this comment.
I asked this last time, but didn't get an answer: why are we using this table here at all? Seems like we are complicating layout both visually and from the code perspective, and the only thing this adds is the table headers that just duplicate the placeholders in the input fields
There was a problem hiding this comment.
Yeah is kinda tricky to align stuff, what you say makes sense to me. I don't know if this has to be a table or we could remove it and keep only the inputs. @Sgrinfy this is more a question for you.
I would keep it as is for now in this PR, and possibly change it in a follow-up one, there are a few other fixes to the new form that would be great to get in before.
3 participants
Jan-31-2022.13-03-52.mp4