fix: replace legacy EJSON with driver’s bson packages EJSON COMPASS-4927 #2757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes COMPASS-5372 (BSON Timestamp stringification) as well.
mcasimir
approved these changes
Feb 3, 2022
We use js-beautify to nicely indent generated JSON strings. Given that this is already a built-in feature of JSON, it seems cleaner and simpler to use that built-in functionality instead of a full-blown JS beautifier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: replace legacy EJSON with driver’s bson packages EJSON COMPASS-4927
This fixes COMPASS-5372 (BSON Timestamp stringification) as well.
chore(compass-crud): drop js-beautify for EJSON
We use js-beautify to nicely indent generated JSON strings. Given
that this is already a built-in feature of JSON, it seems cleaner
and simpler to use that built-in functionality instead of
a full-blown JS beautifier.
Description
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes