Skip to content

fix(connection-model): try catch os dns native MONGOSH-1080 #2759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 3, 2022
Merged

fix(connection-model): try catch os dns native MONGOSH-1080 #2759

merged 1 commit into from
Feb 3, 2022
+10 −5

Conversation

alenakhineika
Copy link
Contributor

@alenakhineika alenakhineika commented Feb 3, 2022 •
edited
Loading

Description

Try/catch requiring os-dns-native so it won't fail in vscode where native addons are not allowed.

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@alenakhineika alenakhineika changed the title fix: try catch os dns native MONGOSH-1080 fix(connection-model): try catch os dns native MONGOSH-1080 Feb 3, 2022
@alenakhineika alenakhineika merged commit 6f232f5 into main Feb 3, 2022
@alenakhineika alenakhineika deleted the MONGOSH-1080-try-catch-os-dns-native branch February 3, 2022 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes

@Anemy Anemy Anemy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alenakhineika @addaleax @Anemy