Skip to content

Conversation

mcasimir
Copy link
Collaborator

@mcasimir mcasimir commented Feb 6, 2022

Noticed we were not setting appName with the new connection form since that feature was done in the old UI

Copy link
Collaborator

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am confused. I thought we had agreed in MONGOSH-1015 and COMPASS-4901 that we do want users to be able to specify their own appName and we do want it to be persisted in that case?

Co-authored-by: Anna Henningsen <anna.henningsen@mongodb.com>
@mcasimir
Copy link
Collaborator Author

mcasimir commented Feb 7, 2022

I am confused. I thought we had agreed in MONGOSH-1015 and COMPASS-4901 that we do want users to be able to specify their own appName and we do want it to be persisted in that case?

Thanks for bringing this up, had no clue it was already implemented in the old model:

  if (typeof connectionModel.appname === 'undefined') {
    connectionModel.appname = electron.remote.app.getName();
  }

Make sense to do this here too. Then we can remove it only if it starts with Mongodb+Compass or something in the convertConnectionModelToInfo

@mcasimir mcasimir merged commit 86c5bba into main Feb 8, 2022
@mcasimir mcasimir deleted the new-connection-screen-app-name branch February 8, 2022 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants