-
Notifications
You must be signed in to change notification settings - Fork 235
feat(connect-form): set appName on connect and don't save it COMPASS-5473 #2764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am confused. I thought we had agreed in MONGOSH-1015 and COMPASS-4901 that we do want users to be able to specify their own appName and we do want it to be persisted in that case?
Co-authored-by: Anna Henningsen <anna.henningsen@mongodb.com>
Thanks for bringing this up, had no clue it was already implemented in the old model:
Make sense to do this here too. Then we can remove it only if it starts with |
Co-authored-by: Anna Henningsen <anna.henningsen@mongodb.com>
Noticed we were not setting appName with the new connection form since that feature was done in the old UI