feat(compass-saved-aggregations-queries): update query/aggregation COMPASS-5506 #2792
Conversation
packages/compass-saved-aggregations-queries/src/components/edit-item-modal.tsx
Outdated
Show resolved
Hide resolved
| onCancel: () => void; | ||
| }; | ||
|
|
||
| const formTitleStyles = css({ |
There was a problem hiding this comment.
You can use this code as a reference to how leafygreen styles this component
There was a problem hiding this comment.
thanks. made it close to this, except for margin-bottom. Sticking to a number provided by spacing that fits.
There was a problem hiding this comment.
Sorry, I should've been more clear, I meant like all the modal styles in this file I linked to: we are missing the divider between controls and confirm etc., but it's fine like that too, I have a ticket for creating a modal form component for compass-components, so we can pick it up later (there are a few other places in compass where it needs to be used anyway)
packages/compass-saved-aggregations-queries/src/components/edit-item-modal.tsx
Outdated
Show resolved
Hide resolved
packages/compass-saved-aggregations-queries/src/stores/edit-item.ts
Outdated
Show resolved
Hide resolved
packages/compass-saved-aggregations-queries/src/components/edit-item-modal.tsx
Outdated
Show resolved
Hide resolved
packages/compass-saved-aggregations-queries/src/components/edit-item-modal.tsx
Outdated
Show resolved
Hide resolved
| onCancel: () => void; | ||
| }; | ||
|
|
||
| const formTitleStyles = css({ |
There was a problem hiding this comment.
Sorry, I should've been more clear, I meant like all the modal styles in this file I linked to: we are missing the divider between controls and confirm etc., but it's fine like that too, I have a ticket for creating a modal form component for compass-components, so we can pick it up later (there are a few other places in compass where it needs to be used anyway)
| import { formatDate } from '../utlis/format-date'; | ||
|
|
||
| export type Action = 'open' | 'delete' | 'copy' | 'rename'; | ||
| export type Action = 'open' | 'delete' | 'copy' | 'edit'; |
There was a problem hiding this comment.
I'd double-check the name with product just in case. IIRC we wanted it to be "Rename" because "Edit" reads as if you can edit the whole thing, but you can only rename it
There was a problem hiding this comment.
Changed it to rename.
| : mapAggregationToItem(action.payload as Aggregation); | ||
| return { | ||
| ...state, | ||
| items: [...state.items.filter((x) => x.id !== action.id), updatedItem], |
There was a problem hiding this comment.
Total nit, but can be done in one go (instead two iterations)
| items: [...state.items.filter((x) => x.id !== action.id), updatedItem], | |
| items: state.items.map((item) => { | |
| if (item.id === action.id) { | |
| return updatedItem; | |
| } else { | |
| return item | |
| } | |
| }), |
2 participants
feat(compass-saved-aggregations-queries): update query/aggregation COMPASS-5506
Description
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes