Skip to content

fix(connection-secrets): hide ssh tunnel password #2799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 17, 2022
Merged

fix(connection-secrets): hide ssh tunnel password #2799

merged 1 commit into from
Feb 17, 2022

Conversation

mabaasit
Copy link
Collaborator

@mabaasit mabaasit commented Feb 17, 2022 •
edited
Loading

fix(connection-secrets): remove sshTunnelPassword from connectionOptions COMPASS-5239

Description

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

mcasimir
mcasimir approved these changes Feb 17, 2022
View reviewed changes
Copy link
Collaborator

@mcasimir mcasimir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@mabaasit mabaasit merged commit 4c41731 into main Feb 17, 2022
@mabaasit mabaasit deleted the COMPASS-5239-hide-ssh-tunnel-password branch February 17, 2022 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcasimir mcasimir mcasimir approved these changes

@addaleax addaleax addaleax approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mabaasit @mcasimir @addaleax