feat(connect-form): enable new connection screen COMPASS-5302 #2807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcasimir
changed the title
mcasimir
changed the title
lerouxb
reviewed
Feb 21, 2022
packages/compass-e2e-tests/helpers/commands/connect-with-connection-form.ts
Outdated
Show resolved
Hide resolved
mcasimir
commented
Feb 21, 2022
| }); | ||
|
|
||
| it('renders the header', () => { | ||
| it.skip('renders the header', () => { |
There was a problem hiding this comment.
I have no idea why this broke, probably just messed with selectors too much or was relying on something I've changed, it should be ok to just skip since we are going to delete this soon
mcasimir
commented
Feb 21, 2022
| dataService.getConnectionOptions().connectionString | ||
| ); | ||
| } catch (e) { | ||
| return '<uri>'; |
There was a problem hiding this comment.
sorry for the "diaper" here, should help with the integration in DE and be innocent in Compass since we have tests that would catch issues. Hopefully will go away soon
mcasimir
force-pushed
the
enable-connect-form
branch
from
991f829 to
fab22b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes