Skip to content

Conversation

mcasimir
Copy link
Collaborator

Fix for favorite pill color.

TLDR; is still not working as before but is not as broken.

Here we disable the dynamic background color on the favorite pill in the sidebar. The reason for doing that are:

  • Color codes were not translated to the new palette and a "light gray" background is displayed in that case
  • The new palette of colors for favorite is not meant to be used as a background as is not creating enough contrast with the foreground. For a similar reason we moved it to an external indicator also in the connection screen.
  • The sidebar redesign removes the favorite pill.

Before:
Screenshot 2022-02-18 at 17 58 34

After:
Screenshot 2022-02-22 at 09 52 02

Screenshot 2022-02-22 at 09 52 16

@mcasimir mcasimir merged commit 76dbf60 into main Feb 22, 2022
@mcasimir mcasimir deleted the fix-favourite-pill branch February 22, 2022 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants