Skip to content

Conversation

mabaasit
Copy link
Collaborator

@mabaasit mabaasit commented Feb 23, 2022

While fixing keys issues, we introduced this issue - on sort or filter of virtual grid list items, the rendered items keep piling up.

GridKeyFix.mov

Description

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@mabaasit mabaasit requested a review from gribnoysup February 23, 2022 16:33
Copy link
Collaborator

@gribnoysup gribnoysup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome catch, thank you!

@mabaasit mabaasit merged commit 8f7fdf2 into main Feb 23, 2022
@mabaasit mabaasit deleted the fix-virtual-grid-key branch February 23, 2022 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants