-
Notifications
You must be signed in to change notification settings - Fork 235
test: move connectivity tests to EVG (without kerberos) #2846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b2ede7e
to
3e6ff17
Compare
|
||
- name: ubuntu_connectivity_tests | ||
display_name: Connectivity Tests | ||
run_on: ubuntu1604-large |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since ubuntu 16.04 has already been EOL for almost a year and this is dockerized anyway, could we maybe use a newer distro like 20.04 here? I assume the build team will be interested in removing 16.04 support at some point
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. If you have a evergreen patch where these are passing, totally let's merge it
COMPASS_SKIP_KERBEROS_TESTS: 'true' | ||
COMPASS_RUN_DOCKER_TESTS: 'true' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not the other ones though? env
supports evergreen expansions. But it's a total nit, so feel free to ignore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't know that, let's move them, is not like that though rn in other functions, I'll try and see what happens i guess, if it works i'll move also the rest
Co-authored-by: Sergey Petushkov <petushkov.sergey@gmail.com>
…-js/compass into enable-connectivity-tests-on-evg
Description
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes