Skip to content

Conversation

mcasimir
Copy link
Collaborator

Description

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@mcasimir mcasimir force-pushed the enable-connectivity-tests-on-evg branch from b2ede7e to 3e6ff17 Compare February 28, 2022 14:50

- name: ubuntu_connectivity_tests
display_name: Connectivity Tests
run_on: ubuntu1604-large
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since ubuntu 16.04 has already been EOL for almost a year and this is dockerized anyway, could we maybe use a newer distro like 20.04 here? I assume the build team will be interested in removing 16.04 support at some point

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

Copy link
Collaborator

@gribnoysup gribnoysup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If you have a evergreen patch where these are passing, totally let's merge it

Comment on lines +316 to +317
COMPASS_SKIP_KERBEROS_TESTS: 'true'
COMPASS_RUN_DOCKER_TESTS: 'true'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not the other ones though? env supports evergreen expansions. But it's a total nit, so feel free to ignore

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't know that, let's move them, is not like that though rn in other functions, I'll try and see what happens i guess, if it works i'll move also the rest

mcasimir and others added 4 commits March 1, 2022 10:39
Co-authored-by: Sergey Petushkov <petushkov.sergey@gmail.com>
…-js/compass into enable-connectivity-tests-on-evg
@mcasimir mcasimir merged commit 42e6142 into main Mar 1, 2022
@mcasimir mcasimir deleted the enable-connectivity-tests-on-evg branch March 1, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants