fix(compass): Catch all errors during theme update #2902
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gribnoysup
force-pushed
the
catch-possible-theme-update-errors
branch
from
0a22c94 to
e8c6abe
Compare
Anemy
approved these changes
Mar 18, 2022
Anemy
reviewed
Mar 18, 2022
There was a problem hiding this comment.
Should we also try catch the loadTheme where we use remote.nativeTheme? I'm thinking that could be a place where the native theme error could come from to be safe.
https://github.com/mongodb-js/compass/blob/main/packages/compass/src/app/theme.js#L45
|
Based on the trace and the error message it happens when we send the message to the window, I'm not sure it makes sense tbh and as this is a hacky workaround I'd try to limit the amount of places where we introduce those |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not a full fix, just a quick workaround based on the reported stack trace. See https://mongodb.slack.com/archives/G2L10JAV7/p1647603276712129