fix(compass-components): Keep the focus in the grid item that received the event #2920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gribnoysup
force-pushed
the
virtual-grid-better-focus
branch
from
e73c252 to
8271595
Compare
gribnoysup
force-pushed
the
virtual-grid-better-focus
branch
from
8271595 to
d4e97a7
Compare
Anemy
approved these changes
Mar 25, 2022
|
It is supported by the hook, so it's only one param passed to the hook away 😄 Both are described in the WCAG as allowed behaviors IIRC, I was just not sure what's the best match here |
… item index on blur
gribnoysup
force-pushed
the
virtual-grid-better-focus
branch
from
165de0b to
9d7f903
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes an issue where interacting with any item in the virtual grid would always automatically move focus to the first element in the grid. This has no behavioral effect when interacting with the grid only with a keyboard or with a mouse, but was causing a visual issue that @Anemy spotted here and a weird keyboard behavior if you would switch from using mouse to keyboard. This new focus / blur handling logic makes sure that the focus is always in sync with whatever and however user is interacting with the items in the list.