feat(data-service): use split CRUD client/Metadata client model COMPASS-5641 #2925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SS-5641 For CSFLE support, we will need Compass to be able to access both server metadata and encrypted collection contents. Using automatic encryption means that a number of administrative commands are not available. As a consequence, for CSFLE-enabled connections, Compass will maintain two separate `MongoClient` instances, and `DataService` methods will pick a specific one depending on what they do. For other connections, there is only a single client.
Anemy
approved these changes
Mar 28, 2022
| */ | ||
| startSession(): ClientSession { | ||
| return this._initializedClient.startSession(); | ||
| startSession(clientType: ClientType): ClientSession { |
There was a problem hiding this comment.
Would it help the typing here if we have a ClientTypeSession (other names?) type that extends the ClientSession with the clientType as a key? Then in killSessions we might not need to do any casting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For CSFLE support, we will need Compass to be able to access both
server metadata and encrypted collection contents.
Using automatic encryption means that a number of administrative
commands are not available. As a consequence, for CSFLE-enabled
connections, Compass will maintain two separate
MongoClientinstances, and
DataServicemethods will pick a specific onedepending on what they do.
For other connections, there is only a single client.
Description
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes