fix(hadron-document, compass-components): Call Editor.start / Editor.complete when changing field value COMPASS-5664 #2942
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These hadron document Editor classes require you to call
start
when starting the edit andcomplete
when done to sorta "commit" edited value to the Element and I completely missed this during refactoring that I did in #2915. Sometimes not doing this has no effect, but really affects the Date type where not doing this results in the field changing types from Date to String on update as reported in this community forum postCOMPASS-5664