feat(aggregations): display aggregation results #2952
Conversation
…s/compass into COMPASS-5669-aggregate-results
...ges/compass-aggregations/src/components/pipeline-toolbar/pipeline-settings/pipeline-name.tsx
Show resolved
Hide resolved
Good idea. Just added it. |
…aggregate-results
| </button> | ||
| </div> | ||
| <div className={containerStyles} data-testid={dataTestId}> | ||
| <SpinLoader size="24px" /> |
| } | ||
| } | ||
|
|
||
| .loader { |
There was a problem hiding this comment.
just curious, why was this necessary?
There was a problem hiding this comment.
nice. the CancelLoader component previously centered the content and also added height: 100%. I removed that and made component occupy width/height it needed and let consumer of the component style it as needed.
| flex-shrink: 1; | ||
| } | ||
|
|
||
| .loader { |
There was a problem hiding this comment.
mostly the same question as above :)
|
🔥🔥🔥 |
There was a problem hiding this comment.
Seems like disabling stages still shows them in the pipeline preview:
I wonder if there is something we can do to make it more obvious that some stages are disabled. I'll add something for this to the design sync.
Another small thing is that scrollbar here is stuck to the items, overlapping with them:
whereas on the builder side it is at the side of the screen. Would be nice to align them, maybe as a follow-up PR.
Otherwise looks really good and works perfectly, great work!
5 participants
feat(aggregations): display aggregation results COMPASS-5669
Screen.Recording.2022-04-06.at.17.06.04.mov
Description
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes