Skip to content

feat(collection): move collection package to TypeScript COMPASS-5695 #2958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Apr 8, 2022
Merged

feat(collection): move collection package to TypeScript COMPASS-5695 #2958

merged 12 commits into from
Apr 8, 2022

Conversation

alenakhineika
Copy link
Contributor

@alenakhineika alenakhineika commented Apr 6, 2022 •
edited
Loading

Description

  • Move collection package to TypeScript and CSS-in-JS
  • Use color themes in compass stats package

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

addaleax
addaleax reviewed Apr 7, 2022
View reviewed changes
Copy link
Collaborator

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! It’s a large PR, nothing much to add here, mostly left a few comments for a few cases where I think we can avoid any without too much effort 👍

@alenakhineika alenakhineika marked this pull request as ready for review April 8, 2022 08:57
@alenakhineika alenakhineika requested a review from addaleax April 8, 2022 10:59
addaleax
addaleax approved these changes Apr 8, 2022
View reviewed changes
Copy link
Collaborator

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! And thank you for doing WorkspaceTabObject, really glad to see that we’re a bit more specific about those 🙂

@alenakhineika alenakhineika merged commit 3c4c17d into main Apr 8, 2022
@alenakhineika alenakhineika deleted the COMPASS-5695-collection-packag-typescript branch April 8, 2022 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alenakhineika @addaleax