feat(aggregations): move maxTimeMS to options COMPASS-5610 #2981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mabaasit
changed the title
…compass into COMPASS-5610-move-maxtime-ms
gribnoysup
reviewed
Apr 14, 2022
| } | ||
|
|
||
| .max-time-ms { | ||
| width: 30%; |
There was a problem hiding this comment.
I don't think this will work well here, this should be a bit more dynamic, probably with a base width in pixels and not percentages, otherwise on small compass window sizes this looks like this:
gribnoysup
reviewed
Apr 14, 2022
| white-space: nowrap; | ||
| border-radius: 14px; | ||
| padding: 2px 1px; | ||
| padding: 2px 4px; |
There was a problem hiding this comment.
padding-left: 4px makes sense to me, but on the right this feels very cramped, maybe let's do padding-right: 8px here?
gribnoysup
reviewed
Apr 14, 2022
| outline-width: 0; | ||
| } | ||
|
|
||
| .max-time-ms { |
There was a problem hiding this comment.
Maybe we can hide the arrow buttons here to make it more like the one in the query bar
gribnoysup
approved these changes
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(aggregations): move maxTimeMS to Options COMPASS-5610
maxTimeMS in collation toolbar
Pipeline builder specific settings only
Collation toolbar post these changes
Collation toolbar prior to these changes
Description
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes