Skip to content

feat(aggregations): fix help text on limit #3003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 20, 2022
Merged

feat(aggregations): fix help text on limit #3003

merged 6 commits into from
Apr 20, 2022
+11 −2

Conversation

mabaasit
Copy link
Collaborator

feat(aggregations): fix help text on limit COMPASS-5611

Description

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

Anemy
Anemy approved these changes Apr 20, 2022
View reviewed changes
Copy link
Member

@Anemy Anemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, one suggestion, I think it's fine as it is as well.

@mabaasit mabaasit merged commit 6e84814 into main Apr 20, 2022
@mabaasit mabaasit deleted the COMPASS-5611-text-change-for-limit branch April 20, 2022 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Anemy Anemy Anemy approved these changes

@gribnoysup gribnoysup gribnoysup approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mabaasit @Anemy @gribnoysup