Skip to content

feat(aggregations): remove add stage button #3008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 22, 2022
Merged

feat(aggregations): remove add stage button #3008

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
14d63aa
feat(aggregations): remove add stage button
mabaasit Apr 20, 2022
5341b56
Merge branch 'main' into COMPASS-5757-hide-add-stage-button
mabaasit Apr 21, 2022
0e34ac4
Merge branch 'main' into COMPASS-5757-hide-add-stage-button
mabaasit Apr 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions ...ass-aggregations/src/components/pipeline-toolbar/pipeline-header/pipeline-stages.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ describe('PipelineStages', function () {
).to.exist;
});

it('renders button to add first stage', function () {
it('renders button to add first stage - when pipeline is empty', function () {
expect(within(container).getByTestId('pipeline-toolbar-add-stage-button'))
.to.exist;
});
Expand Down Expand Up @@ -66,11 +66,14 @@ describe('PipelineStages', function () {
container = screen.getByTestId('toolbar-pipeline-stages');
});
it('renders text to show no stages are in pipeline', function () {
expect(
within(container).findByText(
'Your pipeline is currently empty. To get started select the first stage.'
)
).to.exist;
expect(within(container).findByText('Your pipeline is currently empty.'))
.to.exist;
});

it('does not render button to add first stage - when pipeline is not empty', function () {
expect(() => {
within(container).getByTestId('pipeline-toolbar-add-stage-button');
}).to.throw;
});
});

Expand Down
26 changes: 16 additions & 10 deletions .../compass-aggregations/src/components/pipeline-toolbar/pipeline-header/pipeline-stages.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,16 +54,22 @@ export const PipelineStages: React.FunctionComponent<PipelineStagesProps> = ({
<div className={containerStyles} data-testid="toolbar-pipeline-stages">
{stages.filter(Boolean).length === 0 ? (
<Description className={cx(descriptionStyles)}>
Your pipeline is currently empty. To get started select the&nbsp;
<Link
className={addStageStyles}
as="button"
onClick={() => onStageAdded()}
hideExternalIcon
data-testid="pipeline-toolbar-add-stage-button"
>
first stage.
</Link>
Your pipeline is currently empty.
{stages.length === 0 && (
<>
{' '}
To get started select the&nbsp;
<Link
className={addStageStyles}
as="button"
onClick={() => onStageAdded()}
hideExternalIcon
data-testid="pipeline-toolbar-add-stage-button"
>
first stage.
</Link>
</>
)}
</Description>
) : (
<Pipeline size="small">
Expand Down