feat(data-service): split DataService into interface/implementation #3010
+643
−355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split the `DataService` class into a `DataService` interface and a `DataServiceImpl` implementation class, for better separation between our public API that the components can rely on (and that all other data source providers, e.g. Data Explorer, need to implement as well) and the specific implementation that we use in Compass.
mcasimir
approved these changes
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split the
DataServiceclass into aDataServiceinterface anda
DataServiceImplimplementation class, for better separationbetween our public API that the components can rely on (and that
all other data source providers, e.g. Data Explorer, need to
implement as well) and the specific implementation that we use
in Compass.
Description
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes