feat(aggregation-count): count docs COMPASS-5756 #3011
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aggregation-count
…aggregation-count
…aggregation-count
gribnoysup
reviewed
Apr 21, 2022
Comment on lines
+46
to
+47
| case WorkspaceActionTypes.WorkspaceChanged: | ||
| return INITIAL_STATE; |
There was a problem hiding this comment.
As we are not cleaning up inflight counts when workspace type is changed (both for count and for results), you can run into a pretty nasty race condition where slower, older pipeline results and counts replace content of the newer one. Here's how it looks in UI:
We should definitely fix that both for counts and for results
…aggregation-count
gribnoysup
reviewed
Apr 25, 2022
Comment on lines
+39
to
+42
| if (view === 'builder') { | ||
| dispatch(cancelAggregation()); | ||
| dispatch(cancelCount()); | ||
| } |
There was a problem hiding this comment.
We're definitely getting there. I think you would also want to do this when Run button is pressed if there is an in-flight request running, otherwise I can overload server pretty easily (but more importantly if I'm running a long query and maybe change collation or maxtimems there is a chance of running into race condition issue):
gribnoysup
reviewed
Apr 26, 2022
…s/compass into COMPASS-5756-aggregation-count
Co-authored-by: Sergey Petushkov <petushkov.sergey@gmail.com>
gribnoysup
approved these changes
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(aggregation-count): count docs COMPASS-5756
count aggregation documents
Description
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes