feat(collections): Highlight clustered collections index type COMPASS-5666 #3013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lerouxb
commented
Apr 21, 2022
| <FieldSet> | ||
| <TextInput | ||
| name="clustered.name" | ||
| name="clusteredIndex.name" |
There was a problem hiding this comment.
Bug found while writing the e2e test..
Anemy
reviewed
Apr 21, 2022
| GEOSPATIAL: | ||
| 'https://docs.mongodb.org/manual/applications/geospatial-indexes/#geospatial-indexes', | ||
| WILDCARD: 'https://docs.mongodb.com/manual/core/index-wildcard/', | ||
| // TODO: add an entry for CLUSTERED once the docs become available |
There was a problem hiding this comment.
A similar comment to the one in the first pr - #2966 (comment)
Do we have a ticket name we can attach to this comment? I find it can help give context quickly when looking through code (and then if we somehow miss updating this todo we know way down the line it can be quickly updated).
There was a problem hiding this comment.
https://jira.mongodb.org/browse/COMPASS-5760
And I linked to it from both places
Anemy
reviewed
Apr 21, 2022
packages/index-model/lib/model.js
Outdated
| } | ||
| }, | ||
| type: { | ||
| deps: ['geo', 'hashed', 'text', 'wildcard'], |
There was a problem hiding this comment.
Should clustered also be in this list? I might be misunderstanding how these are used in ampersand.
|
lgtm!
|
Anemy
approved these changes
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up from #2966