Skip to content

Conversation

mabaasit
Copy link
Collaborator

feat(explain-aggregation): add explain button in toolbar COMPASS-5787

Show Explain button in aggregation toolbar with a feature flag.

Description

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

…pipeline-header/pipeline-actions.spec.tsx

Co-authored-by: Rhys <Anemy@users.noreply.github.com>
@mabaasit mabaasit requested a review from Anemy May 12, 2022 16:44
Copy link
Member

@Anemy Anemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Synced offline briefly about modal vs no modal for showing the explain results. Something for design chats

@mabaasit mabaasit merged commit 44c7139 into main May 12, 2022
@mabaasit mabaasit deleted the COMPASS-5787-aggregation-explain-button branch May 12, 2022 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants