Skip to content

Conversation

mabaasit
Copy link
Collaborator

With #3108 we made maxTimeMS nullable and this change throws in DOM as its required by the component. This PR makes it optional in component.

Description

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@mabaasit mabaasit merged commit 3e93295 into main May 23, 2022
@mabaasit mabaasit deleted the maxTimeMS-optional branch May 23, 2022 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants