Skip to content

fix: align elements on the create collection modal COMPASS-5921 #3212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 29, 2022
Merged

fix: align elements on the create collection modal COMPASS-5921 #3212

merged 8 commits into from
Jun 29, 2022

Conversation

alenakhineika
Copy link
Contributor

@alenakhineika alenakhineika commented Jun 27, 2022 •
edited
Loading

Description

  • Options in the advance panel should be aligned. e.g size should be aligned with a capped collection, not with the checkbox.
  • Align (e.g time-series etc.) to the baseline.

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@github-actions github-actions bot added the fix label Jun 27, 2022
@alenakhineika alenakhineika requested a review from gribnoysup June 28, 2022 09:45
Anemy
Anemy reviewed Jun 28, 2022
View reviewed changes
@alenakhineika alenakhineika requested a review from Anemy June 28, 2022 10:41
Anemy
Anemy approved these changes Jun 28, 2022
View reviewed changes
Copy link
Member

@Anemy Anemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

gribnoysup
gribnoysup approved these changes Jun 29, 2022
View reviewed changes
packages/databases-collections/src/components/collation-fields/collation-fields.jsx
Comment on lines +9 to +11
'button:focus, button:focus-within': {
zIndex: 20
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing this is some leafygreen select issue workaround? Might be worth adding a comment here

Copy link
Contributor Author

@alenakhineika alenakhineika Jun 29, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was just moved here from the deleted collation-fields.module.less file.

@alenakhineika alenakhineika merged commit 9dab117 into main Jun 29, 2022
@alenakhineika alenakhineika deleted the COMPASS-5921-create-collection-alignment branch June 29, 2022 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Anemy Anemy Anemy approved these changes

@gribnoysup gribnoysup gribnoysup approved these changes

Assignees

No one assigned

Labels

fix release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alenakhineika @Anemy @gribnoysup