Skip to content

fix(connection-form): align advanced tab and input field widths #3217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 29, 2022
Merged

fix(connection-form): align advanced tab and input field widths #3217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb31a27
fix(connection-form): align advanced tab and input field widths
addaleax Jun 28, 2022
c05cd84
fixup: import lint
addaleax Jun 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions packages/connection-form/src/components/advanced-options-tabs/advanced-tab/advanced-tab.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,6 @@ const containerStyles = css({
marginTop: spacing[3],
});

const fieldStyles = css({
width: '50%',
});

function AdvancedTab({
updateConnectionFormField,
connectionStringUrl,
Expand Down Expand Up @@ -144,7 +140,6 @@ function AdvancedTab({
<FormFieldContainer>
<TextInput
spellCheck={false}
className={fieldStyles}
onChange={({ target: { value } }: ChangeEvent<HTMLInputElement>) => {
handleFieldChanged('replicaSet', value);
}}
Expand All @@ -161,7 +156,6 @@ function AdvancedTab({
<FormFieldContainer>
<TextInput
spellCheck={false}
className={fieldStyles}
onChange={({ target: { value } }: ChangeEvent<HTMLInputElement>) => {
handlePathChanged(value);
}}
Expand Down
1 change: 0 additions & 1 deletion packages/connection-form/src/components/advanced-options-tabs/advanced-tab/url-options.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ import UrlOptionsTable from './url-options-table';

const urlOptionsContainerStyles = css({
marginTop: spacing[3],
width: spacing[6] * 7,
});

const urlOptionsTableDescriptionStyles = css({
Expand Down
1 change: 0 additions & 1 deletion ...ction-form/src/components/advanced-options-tabs/authentication-tab/authentication-tab.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@ const containerStyles = css({

const contentStyles = css({
marginTop: spacing[3],
width: spacing[7] * 5,
});

function getSelectedAuthTabForConnectionString(
Expand Down
2 changes: 0 additions & 2 deletions ...ion-form/src/components/advanced-options-tabs/ssh-tunnel-tab/proxy-and-ssh-tunnel-tab.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,6 @@ const containerStyles = css({

const contentStyles = css({
marginTop: spacing[3],
width: '50%',
minWidth: 400,
});

const getSelectedTunnelType = (
Expand Down
7 changes: 1 addition & 6 deletions ...ction-form/src/components/advanced-options-tabs/tls-ssl-tab/tls-certificate-authority.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import {
Description,
Label,
FileInput,
css,
cx,
} from '@mongodb-js/compass-components';
import {
Expand All @@ -14,10 +13,6 @@ import {

import FormFieldContainer from '../../form-field-container';

const caFieldsContainer = css({
width: '80%',
});

function TLSCertificateAuthority({
tlsCAFile,
useSystemCA,
Expand All @@ -37,7 +32,7 @@ function TLSCertificateAuthority({
) => void;
}): React.ReactElement {
return (
<FormFieldContainer className={caFieldsContainer}>
<FormFieldContainer>
<FileInput
description={
displayDatabaseConnectionUserHints ? 'Learn More' : undefined
Expand Down
9 changes: 2 additions & 7 deletions ...nnection-form/src/components/advanced-options-tabs/tls-ssl-tab/tls-client-certificate.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,8 @@
import React from 'react';
import { FileInput, TextInput, css } from '@mongodb-js/compass-components';
import { FileInput, TextInput } from '@mongodb-js/compass-components';

import FormFieldContainer from '../../form-field-container';

const inputFieldStyles = css({
width: '80%',
});

function TLSClientCertificate({
tlsCertificateKeyFile,
tlsCertificateKeyFilePassword,
Expand All @@ -28,7 +24,7 @@ function TLSClientCertificate({
}): React.ReactElement {
return (
<>
<FormFieldContainer className={inputFieldStyles}>
<FormFieldContainer>
<FileInput
description={
displayDatabaseConnectionUserHints ? 'Learn More' : undefined
Expand Down Expand Up @@ -59,7 +55,6 @@ function TLSClientCertificate({
</FormFieldContainer>
<FormFieldContainer>
<TextInput
className={inputFieldStyles}
onChange={({
target: { value },
}: React.ChangeEvent<HTMLInputElement>) => {
Expand Down
1 change: 1 addition & 0 deletions packages/connection-form/src/components/form-field-container.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import React from 'react';

const formFieldContainerStyles = css({
marginTop: spacing[3],
width: spacing[7] * 6,
});

function FormFieldContainer({
Expand Down