feat(compass-query-history): Add interactive popover, open query history as popover in new query-bar COMPASS-5678 #3321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anemy
added
the
feature flagged
mcasimir
approved these changes
Aug 8, 2022
mcasimir
reviewed
Aug 8, 2022
| boxShadow: '0 0 0 0 transparent', | ||
| }, | ||
| border: `1px solid ${uiColors.gray.light2}`, | ||
| borderRadius: '4px', |
There was a problem hiding this comment.
Is likely that we would want to have this radius aligned everywhere we use one, could be a good thing if we can have variables for this too, along the font sizes, spacings, etc ..
Anemy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature flagged:
This adds and
InteractivePopovercomponent tocompass-components. It uses a focus trap for accessibility. (Version of this package,focus-trap-react, is shared with leafygreen).When the new toolbars are active the query history is opened as a popover. No change to the existing query history.
This pr was separated out of #3312 which had some incorporated feedback on the new component.
query.history.as.popover.mp4