-
Notifications
You must be signed in to change notification settings - Fork 234
INT-1319: Add less compile cache: #336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Precompiles less before check, run, start and in prepublish. Combined the jade template compilation and less compilation into a single compile ui script.
.eslintrc
Outdated
}, | ||
"rules": { | ||
"jsx-quotes": [2, "prefer-single"], | ||
"strict": 0, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- What impact does "strict: 0" have? I don't understand what that value means in this context.
- It looks like you're overriding this rule: https://github.com/mongodb-js/eslint-config/blob/master/rules/strict-mode.js. Should we discuss making this part of our default config?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should - strict mode prevents us from writing invalid Javascript and IMO should be our standard.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm in favor of using strict mode, too. However, what precisely does "strict": 0
do above? As far as I can tell, you disabled the eslint "strict" rule entirely.
See also Lucas' comment in the rule you're overriding:
https://github.com/mongodb-js/eslint-config/blob/master/rules/strict-mode.js
// `'use strict';` is a job for transform tools
// and using it explictly will break them.
TODO:
Otherwise -- hooray! 🎉 This significantly improves application load time, as we expected. |
LGTM |
INT-1319: Add less compile cache: (cherry picked from commit 15d9b0b)
Precompiles less before check, run, start and in prepublish.
Combined the jade template compilation and less compilation into a
single compile ui script.
This change is