feat(compass-indexes): LG table in indexes COMPASS-5940 #3360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| await createModal.waitForDisplayed({ reverse: true }); | ||
|
|
||
| const indexComponent = await browser.$(Selectors.indexComponent('$**_1')); | ||
| const indexComponent = await browser.$(Selectors.IndexComponent('$**_1')); |
There was a problem hiding this comment.
the selectors exported IndexComponent and indexComponent. I removed the latter one as its not required anymore and used IndexComponent :)
|
Nice work! 👏 I have noticed, that in design the create index and refresh buttons are on the right side, have you agreed with Claudia to put them to the left? |
Anemy
reviewed
Aug 19, 2022
packages/compass-indexes/src/components/indexes-table/badge-with-icon-link.tsx
Outdated
Show resolved
Hide resolved
packages/compass-indexes/src/components/indexes-table/indexes-table.tsx
Outdated
Show resolved
Hide resolved
packages/compass-indexes/src/components/indexes-table/property-field.tsx
Outdated
Show resolved
Hide resolved
packages/compass-indexes/src/components/indexes-table/type-field.tsx
Outdated
Show resolved
Hide resolved
packages/compass-indexes/src/components/indexes-toolbar/indexes-toolbar.tsx
Show resolved
Hide resolved
|
Can we have dark mode support already or LG components we use are still missing it?
|
Anemy
reviewed
Aug 19, 2022
|
I created a follow up ticket for making table header fixed and body scrollable. |
Anemy
approved these changes
Aug 22, 2022
packages/compass-indexes/src/components/indexes-toolbar/indexes-toolbar.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Rhys <Anemy@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(compass-indexes): leafygreen table on indexes screen COMPASS-5940
TODO
Description
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes