Skip to content

feat: implement new indexes modal designs COMPASS-5978 #3363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Aug 21, 2022
Merged

feat: implement new indexes modal designs COMPASS-5978 #3363

merged 24 commits into from
Aug 21, 2022

Conversation

alenakhineika
Copy link
Contributor

@alenakhineika alenakhineika commented Aug 18, 2022 •
edited
Loading

Description

Designs:
https://www.figma.com/file/vbjoD4dcisPYRYJ5RRu72k/Compass-LG?node-id=2425%3A61731

  • Implement new designs keeping old branding styles.
  • Move package to TypeScript and CSS-in-JS.
  • Unify the names of props.
  • Dismiss the error message when hitting the white X icon COMPASS-4252
  • Implemented a workaround to fix focus when Combobox is a first element on the form (PD-2321)

Planned follow-up improvements:

  • Test editors, buttons (close, cancel, add field, remove filed), banners (in progress, error) COMPASS-5942
  • Refactor create db/collection modal to use CollapsibleFieldSet from compass-components (including more tests for collapsibleFieldSet) COMPASS-6035

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

Screenshot 2022-08-18 at 17 23 00

@github-actions github-actions bot added the feat label Aug 18, 2022
@alenakhineika alenakhineika added the feature flagged PRs labeled with this label will not be included in the release notes of the next release label Aug 18, 2022
@alenakhineika alenakhineika marked this pull request as ready for review August 18, 2022 16:13
Anemy
Anemy reviewed Aug 18, 2022
View reviewed changes
@alenakhineika alenakhineika requested a review from Anemy August 19, 2022 16:01
Anemy
Anemy reviewed Aug 19, 2022
View reviewed changes
Copy link
Member

@Anemy Anemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, couple comments on banner displays, looking good.

Anemy
Anemy approved these changes Aug 21, 2022
View reviewed changes
Copy link
Member

@Anemy Anemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Nice work, this modal and the controls in it feel a lot nicer to use now. Are we planning to add any indication of the index being created? Currently if you disconnect from wifi and then click create index it doesn’t show any indication something is in progress until the error shows up.

@alenakhineika
Copy link
Contributor Author

alenakhineika commented Aug 21, 2022 •
edited
Loading

Fixed! Thx for noticing this! More testing is coming... COMPASS-6034 :)

@alenakhineika alenakhineika merged commit ae35285 into main Aug 21, 2022
@alenakhineika alenakhineika deleted the COMPASS-5978-new-indexes-modal-designs branch August 21, 2022 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Anemy Anemy Anemy approved these changes

Assignees

No one assigned

Labels

feat feature flagged PRs labeled with this label will not be included in the release notes of the next release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alenakhineika @Anemy