Skip to content

feat: replace partial filter expression input with editor COMPASS-6017, COMPASS-6034 #3392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 26, 2022
Merged

feat: replace partial filter expression input with editor COMPASS-6017, COMPASS-6034 #3392

merged 5 commits into from
Aug 26, 2022

Conversation

alenakhineika
Copy link
Contributor

@alenakhineika alenakhineika commented Aug 26, 2022 •
edited
Loading

Description

  • Replace Partial Filter Expression input with Editor COMPASS-6017
  • Add 8px top and bottom padding to the collapsible field set component
  • Cover create index modal with more test cases: test editors, buttons (close, cancel, add field, remove filed), banners (in progress, error) COMPASS-6034
  • Place wildcard projection before custom collation.

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@github-actions github-actions bot added the feat label Aug 26, 2022
@alenakhineika alenakhineika added the feature flagged PRs labeled with this label will not be included in the release notes of the next release label Aug 26, 2022
@alenakhineika alenakhineika requested a review from mabaasit August 26, 2022 15:00
@alenakhineika alenakhineika merged commit 1511892 into main Aug 26, 2022
@alenakhineika alenakhineika deleted the COMPASS-6017-partial-filter-expression-editor branch August 26, 2022 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcasimir mcasimir mcasimir approved these changes

@mabaasit mabaasit Awaiting requested review from mabaasit

Assignees

No one assigned

Labels

feat feature flagged PRs labeled with this label will not be included in the release notes of the next release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alenakhineika @mcasimir