Skip to content

Conversation

kangas
Copy link
Contributor

@kangas kangas commented Apr 25, 2016

  • Avoid downloading a stable release of MongoDB during before() hook of a test; this will likely cause a test timeout on Evergreen.
  • Reap old Electron procs on Evergreen.

This doesn't resolve INT-958 but gets us closer.


This change is Reviewable

@kangas
Copy link
Contributor Author

kangas commented Apr 25, 2016

patch build: https://evergreen.mongodb.com/version/571e956a3ff1222e2c001080_0

("npm test" is still commented out)

kangas added 2 commits April 26, 2016 12:19
…ron procs

Avoid downloading a stable release of MongoDB during before() hook of a test;
this will likely cause a test timeout on Evergreen.

Reap old Electron procs on Evergreen
@kangas kangas force-pushed the INT-958-spectron-evergreen branch from be69e2d to 1aeddb3 Compare April 26, 2016 16:25
@kangas kangas merged commit 2efca1c into master Apr 26, 2016
@kangas kangas deleted the INT-958-spectron-evergreen branch April 26, 2016 16:27
kangas added a commit that referenced this pull request Apr 26, 2016
…procs (#368)

* INT-958 add pretest task to invoke mongodb-runner, and reap old Electron procs

Avoid downloading a stable release of MongoDB during before() hook of a test;
this will likely cause a test timeout on Evergreen.

Reap old Electron procs on Evergreen

* evergreen: add exec_timeout_secs at 30 min

(cherry picked from commit 2efca1c)
# ${npm|npm} run check
# Create a release build
${npm|npm} run release;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bug

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good grief
On Apr 28, 2016 8:29 AM, "Lucas Hrabovsky" notifications@github.com wrote:

In .evergreen.yml
#368 (comment):

@@ -129,12 +132,12 @@ functions:
# ${npm|npm} run check

     # Create a release build
  •    ${npm|npm} run release;
    

bug


You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub
https://github.com/10gen/compass/pull/368/files/1aeddb3af40e1ed8a357259ff4f0f908e92fef11#r61418353

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, not a bug. See next line below. I simply removed the ${npm|npm} noise in this commit.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah and by removing it it points to the wrong npm installation.

Copy link
Contributor Author

@kangas kangas Apr 28, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we never define "npm" as an evergreen expansion, so the literal "npm" is always used.

PATH is set correctly at the top of the shell.exec script as follows:

export PATH="${node_path}:$PATH"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants