Skip to content

Conversation

durran
Copy link
Member

@durran durran commented Jun 30, 2016

  • Typing : in the key input field tabs to the value input field.
  • Users can now click to the right of the value input field to take the following actions:
    • If the element is the last element in the parent, a new element is added.
    • If a new empty element has already been added, that element is removed.
    • If a new element has been added, with an empty key or value (potential in-progress edit) no action is taken.
  • Only allow addition of 1 element at a time if the field name in the new element is blank.
  • Set newly added key field and value sizes to 1.
  • Fix element auto-focus on add.
  • Added Compass help entries for CRUD.

This change is Reviewable

@durran
Copy link
Member Author

durran commented Jun 30, 2016

cc @marcgurney

@imlucas imlucas self-assigned this Jul 7, 2016
@imlucas
Copy link
Contributor

imlucas commented Jul 7, 2016

Reviewed 16 of 16 files at r2.
Review status: 16 of 17 files reviewed at latest revision, 2 unresolved discussions, some commit checks broke.


src/help/entries/editing-a-single-document.md, line 48 [r2] (raw file):

The changes to a document may be persisted by clicking on the 'Update'
button in the footer of the document panel. Clicking this button will
execute a `$findAndModify` on the server and update the document in the

beautiful for noting this! 👍


src/internal-packages/crud/styles/crud.less, line 147 [r2] (raw file):

  .types {
    display: inline-block;
    position: absolute;

we'll clean this up with flex box later


Comments from Reviewable

@imlucas
Copy link
Contributor

imlucas commented Jul 7, 2016

Reviewed 1 of 7 files at r1.
Review status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks broke.


Comments from Reviewable

@imlucas
Copy link
Contributor

imlucas commented Jul 7, 2016

:lgtm:


Review status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks broke.


Comments from Reviewable

@imlucas imlucas merged commit 31cdc99 into master Jul 7, 2016
@imlucas imlucas deleted the INT-1588 branch July 7, 2016 02:33
imlucas pushed a commit that referenced this pull request Jul 8, 2016
* INT-1588: Fix tabbing order in all edit/insert situations

* INT-1588: Tab to next input on :

* INT-1588: Better usability on ESC

* INT-1588: Usability improvements on hotspot

* INT-1588: Fix input sizes

* INT-1588: Bump compile cache to 0.2.0

* INT-1588: Fixing hotspot functionality

* INT-1589: Add help entries for CRUD

* INT-1588: Remove feature flag, fix insert
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants