INT-1763: Updating auto-casting of numbers. #456
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compass no longer uses the Javascript type
Number
for numbers in the documents, it now uses the correct BSON type for serialization, eitherInt32
,Int64
, orDouble
.This pull also fixes the auto-casting for the numbers. The following behaviour now happens:
Int32
is edited to a value over 32bits, the type automatically casts toInt64
.Int64
is edited to a value over 64bits, the type automatically casts toString
.Int32
is edited to a value over 32bits, the types drop-down contains bothInt64
andDouble
until the value passes (+/-)Number.MAX_SAFE_INTEGER
, then the drop-down only containsInt64
as a numeric value to cast to.This change is