Skip to content

Conversation

mabaasit
Copy link
Collaborator

@mabaasit mabaasit commented Aug 8, 2023

With ampersand, the model always returned default values if they were missing from the storage file. In this PR, I am keeping the same behaviour.

Description

Checklist

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@github-actions github-actions bot added the fix label Aug 8, 2023
@mabaasit mabaasit added the no release notes Fix or feature not for release notes label Aug 8, 2023
@mabaasit mabaasit marked this pull request as ready for review August 8, 2023 12:21
@mabaasit mabaasit merged commit 3b0ebec into main Aug 8, 2023
@mabaasit mabaasit deleted the return-default-preferences branch August 8, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix no release notes Fix or feature not for release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants