-
Notifications
You must be signed in to change notification settings - Fork 234
feat(compass-query-bar): add query ai feedback options COMPASS-7051 #4716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good, but I think we can isolate this form from redux state completely
packages/compass-components/src/components/feedback-popover.tsx
Outdated
Show resolved
Hide resolved
packages/compass-query-bar/src/components/generative-ai/query-feedback.tsx
Outdated
Show resolved
Hide resolved
Oh, actually, a couple of things I spotted when double-checking locally:
|
@gribnoysup Thanks for catching the tab switching behavior. Updated it to dismiss when clicked outside. Also updated the component to close with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice handling of the keyboard events. Two small things I noticed, otherwise looks good
COMPASS-7051
Adds two buttons when there was a successful ai query generation. Submitting the feedback emits a telemetry event with the message.
feedback.example.mp4