Skip to content

fix(preferences): allow empty optional string flags COMPASS-7101 #4725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 15, 2023
Merged

fix(preferences): allow empty optional string flags COMPASS-7101 #4725

merged 2 commits into from
Aug 15, 2023

Conversation

mabaasit
Copy link
Collaborator

@mabaasit mabaasit commented Aug 14, 2023 •
edited
Loading

Description

Checklist

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@github-actions github-actions bot added the fix label Aug 14, 2023
@mabaasit mabaasit changed the title fix(preferences): allow empty optional string flags fix(preferences): allow empty optional string flags COMPASS-7101 Aug 14, 2023
@mabaasit mabaasit marked this pull request as ready for review August 14, 2023 09:01
@mabaasit mabaasit merged commit ee226c2 into main Aug 15, 2023
@mabaasit mabaasit deleted the allow-empty-flags branch August 15, 2023 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gribnoysup gribnoysup gribnoysup approved these changes

Assignees

No one assigned

Labels

fix release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mabaasit @gribnoysup