Skip to content

Conversation

rueckstiess
Copy link
Contributor

@rueckstiess rueckstiess commented Sep 15, 2016

this change disables sending metrics to mixpanel.

Wondering if we should remove the unused keys instead of just commenting them out?


This change is Reviewable

this change disables sending metrics to mixpanel.
Copy link
Contributor

@kangas kangas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to my test using Little Snitch, this not only kills metrics delivery but also stops loading of the mixpanel library. Just as I had hoped. :)

LGTM!

@kangas
Copy link
Contributor

kangas commented Sep 15, 2016

I think it's fine to leave the keys commented-out for now.

@kangas kangas merged commit e93749b into master Sep 15, 2016
@kangas kangas deleted the INT-1774-kill-mixpanel branch September 15, 2016 18:31
kangas pushed a commit that referenced this pull request Sep 15, 2016
this change disables sending metrics to mixpanel.
(cherry picked from commit e93749b)
kangas pushed a commit that referenced this pull request Sep 15, 2016
this change disables sending metrics to mixpanel.
(cherry picked from commit e93749b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants