Skip to content

Conversation

durran
Copy link
Member

@durran durran commented Sep 16, 2016

https://evergreen.mongodb.com/version/57dbe23e3ff122389b000f97

For some reason the icon is not appearing now, but the fix for the original issue works.


This change is Reviewable

@imlucas imlucas self-assigned this Sep 16, 2016
@imlucas
Copy link
Contributor

imlucas commented Sep 16, 2016

I think this might just be the OS X icon cache (I can see the correct compass icon as a hidden file in the dmg). Trying to confirm by restarting a beta task which should pull in hadron-build@0.8.0 and get around the Dev icon cache.

@imlucas
Copy link
Contributor

imlucas commented Sep 19, 2016

Waiting for new patch build on 1.4-releases branch to confirm the icon cache issue.

@imlucas
Copy link
Contributor

imlucas commented Sep 19, 2016

I've now confirmed that this is not an icon cache issue. I downloaded the artifacts from the patch build mentioned above and confirming hadron-build@0.8.0 was used.

I can now see that the icon string in the Info.plist electron-packager is creating is not being replaced properly.

Edit electron-packager renames the icon you give it to electron.icns.

@durran As this seems to be the most critical issue in the queue (1.4.0-beta.0 on OS X does not install properly) and it's already getting late in Berlin, I'd like to reassign INT-1836 to myself to investigate further and prioritize it over my other tasks currently in flight. Does this sound like a good plan to you?

@durran
Copy link
Member Author

durran commented Sep 20, 2016

Sounds good to me.

@imlucas
Copy link
Contributor

imlucas commented Sep 20, 2016

OK I've got icon squared away in my test harness w/ electron-packager@7 and using this strategy for symlinking Electron to ${productName}. Grabbing some lunch then I'll do some final testing, submit a PR to hadron-build and update the version in this compass branch.

@imlucas
Copy link
Contributor

imlucas commented Sep 20, 2016

@durran When you have a chance, could you please take a look at mongodb-js/hadron-build#14 to double check? It implements the symlink strategy described above. If that PR looks good, I'll cut a release of hardon-build and update the version in this PR against compass.

@imlucas
Copy link
Contributor

imlucas commented Sep 21, 2016

Waiting for this patch build using hadron-build@0.9.0 to confirm all fixed and then I will update this PR.

@imlucas imlucas changed the title INT-1836: Bump hadron-build to 0.8.0 INT-1836: Bump hadron-build to 0.9.0 Sep 21, 2016
@imlucas
Copy link
Contributor

imlucas commented Sep 21, 2016

Hmm now I'm getting an error on Evergreen that I'm not able to reproduce locally. Will submit another patch with debugging enabled. Waiting on new patch with debugging enabled.

 [2016/09/21 12:45:54.777] ✖  Error: Error: codesign failed Electron. See output above for more details.
 [2016/09/21 12:45:54.777]     at /data/mci/dd49fa6bc7d7ad1b93318a7f0271ced8/src/node_modules/electron-installer-codesign/index.js:44:10
 [2016/09/21 12:45:54.777]     at ChildProcess.<anonymous> (/data/mci/dd49fa6bc7d7ad1b93318a7f0271ced8/src/node_modules/electron-installer-run/lib/index.js:100:9)
 [2016/09/21 12:45:54.777]     at emitTwo (events.js:106:13)
 [2016/09/21 12:45:54.777]     at ChildProcess.emit (events.js:191:7)
 [2016/09/21 12:45:54.777]     at Process.ChildProcess._handle.onexit (internal/child_process.js:204:12)

@imlucas
Copy link
Contributor

imlucas commented Sep 21, 2016

Now able to repro locally. The problem is we're trying to codesign the Electron symlink. Working on fix.

@imlucas
Copy link
Contributor

imlucas commented Sep 21, 2016

Woot. Resolved above and published in hadron-build@0.9.1. Waiting to confirm in new patch build.

@imlucas
Copy link
Contributor

imlucas commented Sep 21, 2016

@imlucas
Copy link
Contributor

imlucas commented Sep 21, 2016

Confirmed via evergreen. Mergin'!

screenshot 2016-09-21 15 55 04

Direct link to DMG.

@imlucas imlucas changed the title INT-1836: Bump hadron-build to 0.9.0 INT-1836: Bump hadron-build to 0.9.1 Sep 21, 2016
@imlucas imlucas merged commit 394304d into master Sep 21, 2016
@imlucas imlucas deleted the INT-1836 branch September 21, 2016 19:56
imlucas pushed a commit that referenced this pull request Sep 21, 2016
INT-1836: Bump hadron-build to 0.9.1

@see #478
imlucas added a commit that referenced this pull request Sep 22, 2016
Fixes icon and issues described in #478.  To reproduce and verify:

1. [Install Compass
Beta@1.3.0-beta.5](https://downloads.mongodb.com/compass/beta/mongodb-co
mpass-1.3.0-beta.5-darwin-x64.dmg)
2. [Install Compass Beta from this evergreen patch
build](https://s3.amazonaws.com/mciuploads/scout/osx-1010/72849e0f39e773
5a703d2788218b8a357397c13f/mongodb-compass-1.4.0-beta.0-darwin-x64.dmg)
3. Launch Compass, which should succeed and show a new version as
1.4.0-beta.0
imlucas added a commit that referenced this pull request Sep 22, 2016
Fixes icon and issues described in #478.  To reproduce and verify:

1. [Install Compass
Beta@1.3.0-beta.5](https://downloads.mongodb.com/compass/beta/mongodb-co
mpass-1.3.0-beta.5-darwin-x64.dmg)
2. [Install Compass Beta from this evergreen patch
build](https://s3.amazonaws.com/mciuploads/scout/osx-1010/72849e0f39e773
5a703d2788218b8a357397c13f/mongodb-compass-1.4.0-beta.0-darwin-x64.dmg)
3. Launch Compass, which should succeed and show a new version as
1.4.0-beta.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants