-
Notifications
You must be signed in to change notification settings - Fork 233
INT-1836: Bump hadron-build to 0.9.1 #478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I think this might just be the OS X icon cache (I can see the correct compass icon as a hidden file in the dmg). Trying to confirm by restarting a beta task which should pull in |
Waiting for new patch build on 1.4-releases branch to confirm the icon cache issue. |
I've now confirmed that this is not an icon cache issue. I downloaded the artifacts from the patch build mentioned above and confirming
Edit @durran As this seems to be the most critical issue in the queue (1.4.0-beta.0 on OS X does not install properly) and it's already getting late in Berlin, I'd like to reassign INT-1836 to myself to investigate further and prioritize it over my other tasks currently in flight. Does this sound like a good plan to you? |
Sounds good to me. |
OK I've got icon squared away in my test harness w/ |
@durran When you have a chance, could you please take a look at mongodb-js/hadron-build#14 to double check? It implements the symlink strategy described above. If that PR looks good, I'll cut a release of hardon-build and update the version in this PR against compass. |
Waiting for this patch build using |
Hmm now I'm getting an error on Evergreen that I'm not able to reproduce locally.
|
Now able to repro locally. The problem is we're trying to |
Woot. Resolved above and published in |
Confirmed via evergreen. Mergin'! |
Fixes icon and issues described in #478. To reproduce and verify: 1. [Install Compass Beta@1.3.0-beta.5](https://downloads.mongodb.com/compass/beta/mongodb-co mpass-1.3.0-beta.5-darwin-x64.dmg) 2. [Install Compass Beta from this evergreen patch build](https://s3.amazonaws.com/mciuploads/scout/osx-1010/72849e0f39e773 5a703d2788218b8a357397c13f/mongodb-compass-1.4.0-beta.0-darwin-x64.dmg) 3. Launch Compass, which should succeed and show a new version as 1.4.0-beta.0
Fixes icon and issues described in #478. To reproduce and verify: 1. [Install Compass Beta@1.3.0-beta.5](https://downloads.mongodb.com/compass/beta/mongodb-co mpass-1.3.0-beta.5-darwin-x64.dmg) 2. [Install Compass Beta from this evergreen patch build](https://s3.amazonaws.com/mciuploads/scout/osx-1010/72849e0f39e773 5a703d2788218b8a357397c13f/mongodb-compass-1.4.0-beta.0-darwin-x64.dmg) 3. Launch Compass, which should succeed and show a new version as 1.4.0-beta.0
https://evergreen.mongodb.com/version/57dbe23e3ff122389b000f97
For some reason the icon is not appearing now, but the fix for the original issue works.
This change is