Skip to content

Fix "Assignment to const" errors introduced by #486 #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 23, 2016
Merged

Fix "Assignment to const" errors introduced by #486 #491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c6d15c
fix assignment to constants errors
Sep 23, 2016
5f7473d
storeDidChange should not JSON.stringify its contents with %j.
Sep 23, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/internal-packages/query/lib/store/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,7 @@ const QueryStore = Reflux.createStore({
},

storeDidUpdate(prevState) {
debug('query store changed from %j to %j', prevState, this.state);
debug('query store changed from', prevState, 'to', this.state);
}

});
Expand Down
2 changes: 1 addition & 1 deletion src/internal-packages/schema/lib/d3/coordinates.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ const minicharts_d3fns_geo = function() {
// const project = d3.geo.mercator();
// const unproject = d3.geo.mercator().invert;

const update = null;
let update = null;

function querybuilder() {
if (circleCenter && circleOuter) {
Expand Down
13 changes: 7 additions & 6 deletions src/internal-packages/schema/lib/d3/d3-tip.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,10 @@
//
// Returns a tip
return function() {
const direction = d3_tip_direction;
const offset = d3_tip_offset;
const html = d3_tip_html;
const node = initNode();
let direction = d3_tip_direction;
let offset = d3_tip_offset;
let node = initNode();
let html = d3_tip_html;
let svg = null;
let point = null;
let target = null;
Expand All @@ -50,11 +50,12 @@
poffset = offset.apply(this, args),
dir = direction.apply(this, args),
nodel = getNodeEl(),
i = directions.length,
coords = null,
scrollTop = document.documentElement.scrollTop || document.body.scrollTop,
scrollLeft = document.documentElement.scrollLeft || document.body.scrollLeft;

let i = directions.length,
coords = null;

nodel.html(content)
.style({
opacity: 1,
Expand Down
2 changes: 1 addition & 1 deletion src/internal-packages/schema/lib/store/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ const SchemaStore = Reflux.createStore({
},

storeDidUpdate(prevState) {
debug('schema store changed from %j to %j', prevState, this.state);
debug('schema store changed from', prevState, 'to', this.state);
}

});
Expand Down
2 changes: 1 addition & 1 deletion src/internal-packages/status/lib/store/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ const StatusStore = Reflux.createStore({
},

storeDidUpdate(prevState) {
debug('status store changed from %j to %j', prevState, this.state);
debug('status store changed from', prevState, 'to', this.state);
}
});

Expand Down